Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda@Edge with pre-provided zips #205

Closed
syphernl opened this issue Jan 5, 2022 · 2 comments · Fixed by #260 or #262
Closed

Lambda@Edge with pre-provided zips #205

syphernl opened this issue Jan 5, 2022 · 2 comments · Fixed by #260 or #262

Comments

@syphernl
Copy link
Contributor

syphernl commented Jan 5, 2022

Describe the Feature

If would be nice if the Lambda@Edge code could be provided as a zip rather than a piece of plain-text code.

Use Case

Some Lambda@Edge functions might require more files to run (e.g. node_modules).
If a zip could be provided, this would make it possible to run such scripts as well.

Describe Ideal Solution

Add two new variables:

  • create_package - boolean, defaults to true
  • local_existing_package - Path to the existing package to upload
@korenyoni
Copy link
Member

@syphernl thanks for the feature request!

Yes, I think that is a good idea. As the person who implemented the lambda@edge submodule I can say that this was the original idea, but plain text code was faster so I implemented that as an first iteration.

I will take a look!

@syphernl
Copy link
Contributor Author

syphernl commented Jan 5, 2022

@korenyoni Not sure whether you are aware of it but I discovered that work has started on a terraform-aws-lambda-function module as well very recently.
Perhaps this submodule contents can be moved to that module instead?

I read that you implemented it the way it is now because of the Lambda@Edge needs to live in us-east-1.
But since it is possible to pass along providers to modules, it probably would make sense to consolidate the Lambda/Lambda@Edge code into a single module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants