Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lambda@Edge submodule doesn't allow to control log group settings #243

Open
bartelemi opened this issue Sep 13, 2022 · 1 comment
Open

Comments

@bartelemi
Copy link
Contributor

Describe the Feature

Lambda@Edge submodule should allow tweaking the log group settings, like log retention days or kms key. Currently it's creating the log group automatically with default AWS settings, which are not always the most desirable.

Expected Behavior

New variables var.cloudwatch_logs_kms_key_arn and var.cloudwatch_logs_retention_in_days to control the log group settings, with sensible defaults (similar to other modules).

Use Case

Just like for the https://github.com/cloudposse/terraform-aws-lambda-function module, we want to be able to change the log retention days and KMS keys for our lambdas@edge.

Describe Ideal Solution

Introduce 2 new vars as described above, do not create log group automatically, but via the cloudposse/cloudwatch-logs/aws module and tweak the IAM role in this submodule to reflect those changes.

Alternatively, this functionality could be achieved by leveraging the original lambda module, as this lambda@edge submodule is just a more specialized use-case.

Alternatives Considered

As a workaround, we're updating these settings via AWS console.

@szbartnik
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants