Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are many deprecated resources related to S3 #263

Open
alex131290 opened this issue Mar 20, 2023 · 1 comment
Open

There are many deprecated resources related to S3 #263

alex131290 opened this issue Mar 20, 2023 · 1 comment

Comments

@alex131290
Copy link

Describe the Feature

There are a lot of warnings being generated by the module in version 0.82.5

Here's a partial example related to "aws_s3_bucket" resource

  • acl argument is deprecated, Use the aws_s3_bucket_acl resource instead
  • Use the aws_s3_bucket_versioning resource instead
  • cdn.logs/main.tf line 1, in resource "aws_s3_bucket" "default": Use the aws_s3_bucket_server_side_encryption_configuration resource instead

Basically there are deprecated arguments in the following modules/resources:

Expected Behavior

There's a way to replace the aws_s3_bucket resource (https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/0.82.5/main.tf#L232) with terraform-aws-s3-bucket module and with this specific tag (https://github.com/terraform-aws-modules/terraform-aws-s3-bucket/tree/v3.0.1)

Also we'll need to implement something similar for https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/blob/0.82.5/main.tf#L326

Use Case

Removing the warnings which are generated by the module

Describe Ideal Solution

  • Use terraform-aws-s3-bucket module instead of the aws_s3_bucket resource and the same goes for logs module

Alternatives Considered

No response

Additional Context

No response

@andruccho
Copy link
Contributor

Agree, my problem is

resource "aws_s3_bucket" "origin"
Use the aws_s3_bucket_cors_configuration resource instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants