From c759cb0a4e1f50ad83bd1cdd954e55a8c43865fd Mon Sep 17 00:00:00 2001 From: Keith Rozario <795867+keithrozario@users.noreply.github.com> Date: Fri, 10 May 2024 20:29:04 +0800 Subject: [PATCH 1/2] Update README.md Added `name` field to second example. There is a known bug https://github.com/cloudposse/terraform-aws-cloudfront-s3-cdn/issues/151 if the name field is ommited. Might be easier to just update the docs than fix the bug, since it's been open since 2021. --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 0c69a4de..e90ee2de 100644 --- a/README.md +++ b/README.md @@ -86,6 +86,7 @@ module "cdn" { aliases = ["assets.cloudposse.com"] dns_alias_enabled = true parent_zone_name = "cloudposse.com" + name = "prod" } ``` From 770754f5648f274a71b316fcea0da988cc90000f Mon Sep 17 00:00:00 2001 From: Keith Rozario Date: Sat, 11 May 2024 16:55:46 +0800 Subject: [PATCH 2/2] added name to 2nd example --- README.md | 2 +- README.yaml | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index e90ee2de..5d372b53 100644 --- a/README.md +++ b/README.md @@ -86,7 +86,7 @@ module "cdn" { aliases = ["assets.cloudposse.com"] dns_alias_enabled = true parent_zone_name = "cloudposse.com" - name = "prod" + name = "eg-prod-app" } ``` diff --git a/README.yaml b/README.yaml index 9e034cbd..823d1def 100644 --- a/README.yaml +++ b/README.yaml @@ -98,6 +98,7 @@ usage: |2- aliases = ["assets.cloudposse.com"] dns_alias_enabled = true parent_zone_name = "cloudposse.com" + name = "eg-prod-app" } ```