support-kms-key-id-for-root-volume #128
Conversation
![bridgecrew[bot]](https://avatars.githubusercontent.com/in/52968?s=60&v=4){kind=small}
| @@ -141,6 +141,7 @@ resource "aws_instance" "default" { | |||
| iops = local.root_iops | |||
| delete_on_termination = var.delete_on_termination | |||
| encrypted = var.root_block_device_encrypted | |||
| kms_key_id = var.root_block_device_kms_key_id | |||
There was a problem hiding this comment.
Ensure that EC2 is EBS optimized
Resource: aws_instance.default | ID: BC_AWS_GENERAL_68
How to Fix
resource "aws_instance" "foo" {
...
+ ebs_optimized = true
}Description
TBAThere was a problem hiding this comment.
@nitrocode what's the best way to address this, since optimization isn't in the scope of this PR?
There was a problem hiding this comment.
There was a problem hiding this comment.
@woz5999 I would just add a new input called ebs_optimized and default it to true.
There was a problem hiding this comment.
@nitrocode upon further inspection, it looks like the var already exists and is applied to the instance, but is defaulted to false. I'm happy to make the change to update the default, but the advisability of that is probably for someone at cloudposse to decide. lmk what you prefer.
There was a problem hiding this comment.
@nitrocode any guidance here?
There was a problem hiding this comment.
No worries then. We can fix that in a follow up pr.
|
/rebuild-readme |
Co-authored-by: nitrocode <[email protected]>
|
/rebuild-readme |
|
/test all |
|
/test all |
* support-kms-key-id-for-root-volume * Auto Format * Update variables.tf Co-authored-by: nitrocode <[email protected]> * Auto Format * Update main.tf * Update variables.tf * Update main.tf * Auto Format Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: nitrocode <[email protected]>
* support-kms-key-id-for-root-volume * Auto Format * Update variables.tf Co-authored-by: nitrocode <[email protected]> * Auto Format * Update main.tf * Update variables.tf * Update main.tf * Auto Format Co-authored-by: cloudpossebot <[email protected]> Co-authored-by: nitrocode <[email protected]>
what
why