Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for gp3 and io2 both root and ebs volumes (fixed copy of #117) #136

Merged
merged 12 commits into from
Sep 14, 2022
Merged

Added support for gp3 and io2 both root and ebs volumes (fixed copy of #117) #136

merged 12 commits into from
Sep 14, 2022

Conversation

tbpoetke
Copy link
Contributor

@tbpoetke tbpoetke commented Aug 22, 2022 •
edited by nitrocode
Loading

what

  • Added support for io2 and gp3 volumes

why

  • original PR had conflicts, this will work hopefully
  • io2 and gp3 are new more performant volumes therefore they should be supported

references

@tbpoetke tbpoetke requested review from a team as code owners August 22, 2022 19:13
@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

@tbpoetke please bump modules in the examples in order to successfully pass the test/bats check

https://github.com/tbpoetke/terraform-aws-ec2-instance/blob/master/examples/complete/main.tf

@tbpoetke
Copy link
Contributor Author

tbpoetke commented Sep 12, 2022 •
edited
Loading

@tbpoetke please bump modules in the examples in order to successfully pass the test/bats check

https://github.com/tbpoetke/terraform-aws-ec2-instance/blob/master/examples/complete/main.tf
@nitrocode
Modules updated

@nitrocode
Copy link
Member

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

@tbpoetke
Copy link
Contributor Author

@tbpoetke unfortunately after bumping the modules, there are also some breaking changes with the interface. Please ensure that the examples/complete module plans locally successfully and I will re-run tests.

ok, I will try to fix it, thanks for your help!

@tbpoetke
Copy link
Contributor Author

tbpoetke commented Sep 12, 2022 •
edited
Loading

@nitrocode should work now, terraform validate and terraform plan no more errors, please retry the Github Action test. Thank you!

@nitrocode
Copy link
Member

/test all

@tbpoetke
Copy link
Contributor Author

Ok, will fix it again tomorrow ....sorry for the circumstances ...

tbpoetke
tbpoetke commented Sep 12, 2022
View reviewed changes
Copy link
Contributor Author

@tbpoetke tbpoetke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the deprecated syntax. Locally it's working for me, idk why the tests are failing!

@nitrocode
Copy link
Member

/test all

@nitrocode
Copy link
Member

@tbpoetke more yak shaving... please bump the required terraform version to > 1.0 in versions.tf and examples/complete/versions.tf

@tbpoetke
Copy link
Contributor Author

It's a long ride through this pipeline 🔢

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit 1bc0487 into cloudposse:master Sep 14, 2022
@nitrocode
Copy link
Member

Thank you so much for the contribution @tbpoetke ! I know it was a bit arduous. Future PRs will be easier.

@tbpoetke
Copy link
Contributor Author

tbpoetke commented Sep 14, 2022 •
edited
Loading

Thank you for your review and your help @nitrocode . Next time I will try to test the pipeline with act to avoid such problems ....

@RothAndrew RothAndrew mentioned this pull request Sep 28, 2022
Closed
joelsdc pushed a commit to TRIPP-Inc/terraform-aws-ec2-instance that referenced this pull request Apr 10, 2023
@tbpoetke @cloudpossebot @joelsdc
Added support for gp3 and io2 both root and ebs volumes (fixed copy of …
a2745ae 
…cloudposse#117) (cloudposse#136)

* adding gp3 volume

* fmt

* Auto Format

* fix variables

* update modules

* fix examples to be inline with new module versions

* remove deprecated syntax

* upgrade required terraform version

* Auto Format

* fix provider in examples

Co-authored-by: Tommy <[email protected]>
Co-authored-by: cloudpossebot <[email protected]>
Co-authored-by: Tommy <[email protected]>
joelsdc pushed a commit to TRIPP-Inc/terraform-aws-ec2-instance that referenced this pull request Apr 10, 2023
@tbpoetke @cloudpossebot @joelsdc
Added support for gp3 and io2 both root and ebs volumes (fixed copy of …
a14bf2e 
…cloudposse#117) (cloudposse#136)

* adding gp3 volume

* fmt

* Auto Format

* fix variables

* update modules

* fix examples to be inline with new module versions

* remove deprecated syntax

* upgrade required terraform version

* Auto Format

* fix provider in examples

Co-authored-by: Tommy <[email protected]>
Co-authored-by: cloudpossebot <[email protected]>
Co-authored-by: Tommy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue handling 'io2' and 'gp3' volume types
3 participants
@tbpoetke @nitrocode @cloudpossebot