Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #156

Closed
pguinard-public-com opened this issue Dec 15, 2022 · 0 comments · Fixed by #157
Closed

Remove unused dependencies #156

pguinard-public-com opened this issue Dec 15, 2022 · 0 comments · Fixed by #157
Labels
bug 🐛 An issue with the system

Comments

@pguinard-public-com
Copy link
Contributor

Describe the Bug

required_providers { local ... } is not required as locals are built into terraform. The local provider provides the following:

  • resource.local_file
  • resource.local_sensitive_file
  • data.local_file
  • data.local_sensitive_file

Expected Behavior

Not install a provider that is not required in order to speed up the terraform init process.

Steps to Reproduce

Sample terraform code

module "container_definition" {
  source  = "cloudposse/ecs-container-definition/aws"
  version = "0.58.1"

  container_name  = "app"
  container_image = "image:latest"
}
$ terraform providers

Providers required by configuration:
.
├── provider[registry.terraform.io/hashicorp/aws]
├── module.container_definition
│   └── provider[registry.terraform.io/hashicorp/local] >= 1.2.0

Screenshots

If applicable, add screenshots or logs to help explain your problem.

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:

  • OS: All
  • Version 0.13+

Additional Context

Add any other context about the problem here.

@pguinard-public-com pguinard-public-com added the bug 🐛 An issue with the system label Dec 15, 2022
bion referenced this issue in civiform/cloud-deploy-infra Apr 3, 2023
…126)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[cloudposse/ecs-container-definition/aws](https://registry.terraform.io/modules/cloudposse/ecs-container-definition/aws)
([source](https://togithub.com/cloudposse/terraform-aws-ecs-container-definition))
| module | patch | `0.58.1` -> `0.58.2` |

---

### Release Notes

<details>
<summary>cloudposse/terraform-aws-ecs-container-definition</summary>

###
[`v0.58.2`](https://togithub.com/cloudposse/terraform-aws-ecs-container-definition/releases/tag/0.58.2)

[Compare
Source](https://togithub.com/cloudposse/terraform-aws-ecs-container-definition/compare/0.58.1...0.58.2)

<details>
<summary>Remove unused provider @&#8203;pguinard-public-com
(#&#8203;157)</summary>

#### what
* Remove unused provider

#### why
* Do not download the [provider for local.file and
local.sensitive_file](https://registry.terraform.io/providers/hashicorp/local/latest/docs/resources/file)
as this is not required for the module to run
* This makes terraform init run faster as well as download resources
that are not used

#### references
* Local provider that is being defined
([https://github.com/cloudposse/terraform-aws-ecs-container-definition/issues/156](https://togithub.com/cloudposse/terraform-aws-ecs-container-definition/issues/156))
* closes #&#8203;156 

</details>

<details>
<summary>git.io->cloudposse.tools update @&#8203;dylanbannon
(#&#8203;152)</summary>

#### what and why 
Change all references to `git.io/build-harness` into
`cloudposse.tools/build-harness`, since `git.io` redirects will stop
working on April 29th, 2022.

#### References
- DEV-143
</details>

#### 🤖 Automatic Updates

<details>
<summary>Update README.md and docs @&#8203;cloudpossebot
(#&#8203;155)</summary>

#### what
This is an auto-generated PR that updates the README.md and docs

#### why
To have most recent changes of README.md and doc from origin templates
</details>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/civiform/cloud-deploy-infra).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTIuNCIsInVwZGF0ZWRJblZlciI6IjM0LjE1Mi40In0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant