Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to context.tf #5

Merged
merged 4 commits into from
Aug 30, 2020
Merged

Convert to context.tf #5

merged 4 commits into from
Aug 30, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Aug 28, 2020

what

  • Convert to context.tf
  • Implement enabled flag
  • Enhance example
  • Updated lint.yml to remove superlinter and use latest version of build-harness for readme linting.

why

  • Standardize
  • Demonstrate how to avoid creating resources when not enabled
  • Latest version of build-harness is used to build README and same version needs to be used to lint it.
  • Superlinter is not ready for production. There is a bug in the go linting and problems with terrascan. This can be added back once the project gets a bit more mature.

@Nuru Nuru requested a review from a team as a code owner August 28, 2020 21:16
@osterman
Copy link
Member

Would it be quick to also update it to go modules?

htplbc
htplbc previously approved these changes Aug 28, 2020
@Nuru Nuru requested a review from a team as a code owner August 28, 2020 22:37
@Nuru
Copy link
Contributor Author

Nuru commented Aug 28, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Aug 28, 2020

/test all

@Nuru Nuru merged commit 3a6464e into master Aug 30, 2020
@Nuru Nuru deleted the context branch August 30, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants