Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish script crashes hard on malformed YAML in limits.yaml #102

Open
boegel opened this issue Feb 19, 2021 · 1 comment
Open

finish script crashes hard on malformed YAML in limits.yaml #102

boegel opened this issue Feb 19, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@boegel
Copy link
Contributor

boegel commented Feb 19, 2021

[citc@mgmt ~]$ cat limits.yaml
c5d.2xlarge:10
[citc@mgmt ~]$ finish
Traceback (most recent call last):
  File "/usr/local/bin/update_config", line 89, in <module>
    node_config = "\n".join(get_node_configs(get_limits(), get_shapes(), get_mgmt_info(), get_nodespace()))
  File "/usr/local/bin/update_config", line 67, in get_node_configs
    for shape, shape_counts in limits.items():
AttributeError: 'str' object has no attribute 'items'

That's a pretty complicated way of saying "please add a space after the ':'" :)

@milliams milliams added the enhancement New feature or request label Feb 19, 2021
@milliams
Copy link
Member

We've had issues like this before and started a fix at #39 but it never got tested and merged. I think it's useful to improve the error reporting here as you say :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants