Find cmder files when running as Administrator. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting a shell as Administrator, the CMDER_ROOT variable is not propagated from the parent (non-Admin) environment. Fix this by using paths relative to %ConEmuDir%. Fixes issue cmderdev#94.
Extra quotes in previous commit caused PATH to be set incorrectly in admin shell.
| @@ -2,6 +2,11 @@ | |||
| :: Sets some nice defaults | |||
| :: Created as part of cmder project | |||
|
|
|||
| :: Find root dir | |||
| @if not defined CMDER_ROOT ( | |||
| for /f %%i in ("%ConEmuDir%\..\..") do @set CMDER_ROOT=%%~fi | |||
There was a problem hiding this comment.
changing this line to:
for /f "delims=?" %%i in ("%ConEmuDir%\..\..") do @set CMDER_ROOT=%%~fi
makes this work when cmder is installed to a path with spaces.
|
+1 |
MartiUK
added a commit
that referenced
this pull request
Aug 27, 2014
Find cmder files when running as Administrator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a shell as Administrator, the CMDER_ROOT variable is
not propagated from the parent (non-Admin) environment.
Fix this by using paths relative to %ConEmuDir%.
Fixes issue #94.