Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework alias command to not to use external tools #358

Merged
merged 5 commits into from
Jan 8, 2015

Conversation

vladimir-kotikov
Copy link
Contributor

This includes following changes:

  1. Adds handling of duplicate aliases internally by alias script instead of external perl script.
  2. Adds additional /d option to remove already defined alias (and replaces unalias.bat -> unalias alias :) ).
  3. Adds the way to show defined aliases by typing alias command without arguments.

@vladimir-kotikov vladimir-kotikov changed the title Rework alias command to not use external tools Rework alias command to not to use external tools Dec 29, 2014
@vladimir-kotikov
Copy link
Contributor Author

@MartiUK, @Bliker PTAL

:p_show
type "%ALIASES%" || echo No aliases found at "%ALIASES%"
goto :eof

:p_help
echo.Usage:
echo. alias name=full command
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe replace with:

echo.   alias [/reload] [/d] [name=full command]
echo.     /reload  Reload the aliases file
echo.     /d       Delete an alias (must be followed by the alias name)
echo.
echo.   If alias is called with any parameters, it will display the list of existing aliases.
echo.   In the command, you can use the following notations:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Done in vladimir-kotikov@dba00b9

@narnaud
Copy link
Contributor

narnaud commented Jan 8, 2015

+1 from me, I'm actually using it ;)

Thanks

@vladimir-kotikov
Copy link
Contributor Author

You're welcome! :)

MartiUK added a commit that referenced this pull request Jan 8, 2015
Rework `alias` command to not to use external tools
@MartiUK MartiUK merged commit 6c69536 into cmderdev:development Jan 8, 2015
@MartiUK
Copy link
Member

MartiUK commented Jan 8, 2015

Looks good, thanks @vladimir-kotikov

@vladimir-kotikov
Copy link
Contributor Author

Thanks for merging @MartiUK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants