Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard path for ConEmu.xml #600

Merged
merged 2 commits into from
Oct 12, 2015

Conversation

Maximus5
Copy link
Contributor

Placing xml file in the unusual location restricts or limits users from

  • pin cmder to TaskBar;
  • using "ConEmu here" feature;
  • using "DefTerm" feature.

Details are here: Maximus5/ConEmu#277

@Stanzilla
Copy link
Member

Well, looks like you are awesome, thanks :)

@r3Fuze
Copy link

r3Fuze commented Aug 19, 2015

This becomes a problem when building this project. Running the build scripts will delete the conemu-maximus5 folder before downloading a new version. Also, all the vendor files are ignored from .gitignore so the file will never be checked into git.

I guess this is something that would have to be worked around inside the build script.

@Maximus5
Copy link
Contributor Author

That is not a problem. As you may see, file is copied if it is absent.
And if you want to preserve it on rebuild (?) just add copy back to config before deletion.

@Maximus5
Copy link
Contributor Author

Maximus5 commented Sep 1, 2015

eec3fd5 - Backup and restore ConEmu.xml on ./build.ps1

@Maximus5
Copy link
Contributor Author

One more drawback of "current" scheme. All settings are reset to defatuls when user unpack new cmder version. Proposed patch will preserve user changes made in ConEmu.xml on unpacking cmder.7z into existing installation.

@Stanzilla
Copy link
Member

Thanks, manually merged it into my fork.

Stanzilla added a commit that referenced this pull request Oct 12, 2015
Use standard path for ConEmu.xml
@Stanzilla Stanzilla merged commit 568e2cf into cmderdev:development Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants