Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bake npm and related ui dependencies into builder image #2058

Closed
petermattis opened this issue Aug 11, 2015 · 1 comment
Closed

ci: bake npm and related ui dependencies into builder image #2058

petermattis opened this issue Aug 11, 2015 · 1 comment
Assignees
@tamird

Comments

@petermattis
Copy link
Collaborator

Every CI build reinstalls mocha, stylus, tslint, typescript, chai and probably some other items. It should be possible bake these deps into the builder image. See build/builder.sh init. The old deps-docker.sh script accomplished this for the cockroachdb/cockroach-dev image, but I think the technique will have to be modified for build/builder.sh init. Or maybe not, I haven't looked in depth.
This was referenced Sep 18, 2015
Merged
Closed
@tamird
Copy link
Contributor

tamird commented Sep 20, 2015

Caching this stuff saved 2 seconds, so this is not worth the trouble. Closing.

@tamird tamird closed this as completed Sep 20, 2015
@tamird tamird mentioned this issue Sep 29, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamird tamird

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tamird @petermattis