Skip to content

Commit

Permalink
Downgrade go version requirement to 1.19
Browse files Browse the repository at this point in the history
Previously, we had upgraded this library to be compatible with a
number of features introduced in go 1.20. Our compatibility with the
multi-cause errors does not depend on those features being available
in the stdlib so the requirement in go.mod is being downgraded to
1.19.

This removes the need for an older compatibility branch released as
version 1.10.1 of this library.

Go 1.20 features are only necessary to run tests. GitHub actions are
adjusted to additionally test for a successful build on 1.19.
  • Loading branch information
dhartunian committed Aug 28, 2023
1 parent fed2d3b commit fe94800
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 1 deletion.
17 changes: 17 additions & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,24 @@ on:
branches: [ master ]

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
go:
- "1.18"
- "1.19"
- "1.20"
steps:
- uses: actions/checkout@v3

- name: Set up Go (${{ matrix.go }}
uses: actions/setup-go@v4
with:
go-version: ${{ matrix.go }}

- name: Build (${{ matrix.go }})
run: go build ./...
build-and-test:
runs-on: ubuntu-latest
strategy:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/cockroachdb/errors

go 1.20
go 1.19

require (
github.com/cockroachdb/datadriven v1.0.2
Expand Down

0 comments on commit fe94800

Please sign in to comment.