chore(bump): Update codacy-analysis-core to 7.9.4 #147
Conversation
| @@ -25,10 +23,7 @@ nativeImageOptions ++= Seq("--enable-http", | |||
| "--no-fallback", | |||
| "--report-unsupported-elements-at-runtime") | |||
|
|
|||
| // Scalafix | |||
|
|
|||
| ThisBuild / scalafixDependencies += "com.github.liancheng" %% "organize-imports" % "0.6.0" | |||
There was a problem hiding this comment.
Was this removed temporarily and forgot to add back, or you want to propose to remove them?
There was a problem hiding this comment.
it's included in the new version of scalafix
| protected def createFullToolSpec(toolSpec: ToolSpec, | ||
| dockerToolDocumentation: DockerToolDocumentation): FullToolSpec = { | ||
| val patterns = | ||
| dockerToolDocumentation.toolSpecification |
There was a problem hiding this comment.
is the .toolSpecification the same as toolSpec? For me seems a bit strange that this method receives a toolSpec and a dockerToolDocumentation but then all the code is transformations only relying on dockerToolDocumentation.
Also assume that some if you replace some .map with .flatMap we may avoid some flattens / getOrElse? But we can take a look together
| PluginPrefixHelper.prefixDescription(toolPrefix, patternDescriptions) | ||
| } | ||
|
|
||
| @deprecated( |
There was a problem hiding this comment.
Is this a copy paste form the codacy-plugins or something? Or what is the idea of this deprecated?
| import java.nio.file.{Files, Path} | ||
| import scala.util.{Properties, Try} | ||
|
|
||
| class BinaryDockerHelper extends DockerHelper { |
There was a problem hiding this comment.
Similar to the other added files, are we adding because it got removed or something? Was this code on codacy-plugins before but now is not available?
sure 👍 |
No description provided.