Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: waitNumberOfVisibleElements always failed when passing num as 0 #4274

Merged
merged 2 commits into from
Mar 29, 2024
Merged

fix: waitNumberOfVisibleElements always failed when passing num as 0 #4274

merged 2 commits into from
Mar 29, 2024

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent merged commit c2ca7e6 into 3.x Mar 29, 2024
13 checks passed
@kobenguyent kobenguyent deleted the fix-waitNumberOfVisibleElements branch March 29, 2024 04:17
@kobenguyent kobenguyent mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug playwright puppeteer webdriver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I.waitNumberOfVisibleElements('locator', 0) always fails
1 participant
@kobenguyent