fix: no error thrown from rerun script #4494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lin-brian-l
commented
Sep 13, 2024
Comment on lines
-20
to
-23
| function processError(err) { | ||
| printError(err) | ||
| process.exit(1) | ||
| } |
There was a problem hiding this comment.
This function was unused.
| @@ -96,4 +96,18 @@ describe('run-rerun command', () => { | |||
| }, | |||
| ) | |||
| }) | |||
|
|
|||
| it('should throw exit code 1 if all tests were supposed to pass', (done) => { | |||
There was a problem hiding this comment.
I've verified that this test fails without my changes.
32 tasks
32 tasks
This reverts commit 6cba723.
kobenguyent
changed the title
|
@kobenguyent thanks for taking a look at this! Not to rush, but do you know when this would be ready to merge? I've made a similar PR for a fork on my team's repository but we were wondering if we should just wait for this PR to be merged instead. Let me know if you'd like for me to address any feedback! |
|
@lin-brian-l we are planning to release very soon. Thanks for your contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Our team observed that using
codeceptjs run-rerunwould only throw an exit code of1if the last test failed, making it difficult to reliably determine if a test in the suite actually was flaky. After some investigating, we determined that it's because thecatchstatement inrun-rerun.jswas never being called due torerun.jsnever actually throwing the error.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)