Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drupal] Change Event Date and Time handling #44

Closed
Lowell20 opened this issue May 31, 2016 · 9 comments
Closed

[Drupal] Change Event Date and Time handling #44

Lowell20 opened this issue May 31, 2016 · 9 comments
Milestone

Comments

@Lowell20
Copy link
Contributor

To make similar to balsamics, I've changed the date to a year, month, date storage format.
This also makes searching by date much easier.
Example:
/api/events/2016--5-31
will return any event with that date.
The times are handled as integers now with an hour field and a minute field.
Also a duration field

@Lowell20
Copy link
Contributor Author

I haven't pushed to live site yet, oops, only one dash between year and month.
Posting issue to share format requirements

@Lowell20
Copy link
Contributor Author

I will close the issue when it is done

@AnthonyAstige
Copy link
Member

AnthonyAstige commented May 31, 2016

Per our discussion on UTC yesterday, and the note about that the api request url doesn't include a precise time, I'm going to assume the API filters by local Eau Claire time.

@AnthonyAstige AnthonyAstige changed the title Event Date and Time handling has changed [Drupal] Change Event Date and Time handling May 31, 2016
@AnthonyAstige AnthonyAstige added this to the MVP milestone May 31, 2016
@Lowell20
Copy link
Contributor Author

Lowell20 commented May 31, 2016

If we implement this change to match the balsamic administration ui then
utc doesn't matter any more.

Dates are stored as y-m-d. Easy peasy

@AnthonyAstige
Copy link
Member

Yeah makes sense, it simplifies a couple things for us.

@Lowell20
Copy link
Contributor Author

ok, it is actuall yyyy-mm-dd, like 2016-06-01

@Lowell20
Copy link
Contributor Author

the admin end is pushed to live environment, now the consumer needs to be adjusted to match

@Lowell20
Copy link
Contributor Author

Lowell20 commented May 31, 2016

date: "2016-05-31",
duration: "120",
start_hour: "10",
start_minute: "0",

this json snippet shows today at 10:00am until 12:00noon

@Lowell20 Lowell20 removed their assignment May 31, 2016
@AnthonyAstige
Copy link
Member

the admin end is pushed to live environment, now the consumer needs to be adjusted to match

Depending on the direction the conversation goes in #46 (comment).

In either case that's another issue, and sounds like the core of this one is done, so I'll close this one. Feel free to re-open if I'm mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants