Update Error prone 2.4 #81
Conversation
|
This would solve #77, wouldn't it? |
|
Yes. I just had a look at the failing builds : mac builds fail on j2objc missing , need activate profile to skip tests; jdk14 tests fail on additional warnings since jdk11 |
|
@nicerloop ah yes sorry for the failing ghactions, I just added that yesterday and obviously some are failing for bad reasons. |
| public void setUp() | ||
| throws Exception | ||
| { | ||
| super.setUp(); | ||
| setForceJavacCompilerUse( true ); | ||
| if ( java8() ) { |
There was a problem hiding this comment.
does it mean we do not test with new jdk such 14?
There was a problem hiding this comment.
I did test on LTS jdk8 and jdk11, and warning count changes ; I did not test with other jdk
There was a problem hiding this comment.
I disable the j2objc test for ghactions.
Still some issues with jdk14
There was a problem hiding this comment.
@nicerloop rebase with master I have disabled jdk14 until we get this fixed
There was a problem hiding this comment.
I locally have issues with jdk14 in plexus-compiler-eclipse("The type java.lang.Object cannot be resolved") and plexus-compiler-javac (source/target 1.6 not supported anymore, use 7 or later)
There was a problem hiding this comment.
It seems to me master does not build with jdk14
nicerloop
force-pushed
the
error-prone-2.4
branch
from
e4cf626 to
33fd480
Compare
|
Rebased on master, all checks OK. |
…avax.tools.JavaCompiler
nicerloop
force-pushed
the
error-prone-2.4
branch
from
33fd480 to
b7f6893
Compare
|
Rebased on master |
Update error-prone to 2.4.0 using ErrorProneJavaCompiler implementation of java.tools.JavaCompiler based on plexus-compiler-javac