Skip to content

Commit

Permalink
Use machine settings for e2e tests
Browse files Browse the repository at this point in the history
User settings are browser-based so use machine settings instead.
  • Loading branch information
code-asher committed Nov 21, 2023
1 parent 09dd5fe commit 9ba66ec
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/e2e/models/CodeServer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ export class CodeServer {
*/
private async createWorkspace(): Promise<string> {
const dir = await this.workspaceDir
await fs.mkdir(path.join(dir, "User"), { recursive: true })
await fs.mkdir(path.join(dir, "Machine"), { recursive: true })
await fs.writeFile(
path.join(dir, "User/settings.json"),
path.join(dir, "Machine/settings.json"),
JSON.stringify({
"workbench.startupEditor": "none",
}),
Expand Down

2 comments on commit 9ba66ec

@benz0li
Copy link
Contributor

@benz0li benz0li commented on 9ba66ec Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@code-asher Due to commit 73cb236 (Add back local storage patch): Shouldn't this be reverted, too?

@code-asher
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was not sure, it works either way but maybe it is better to use User to test that the settings are being read from disk.

Please sign in to comment.