Local build fails after node update to version 20.11.1

[OCram85]

just updated my forks and noticed the build fails after nodejs was updated to node 20.11.1. CI pipeline definition for testing

It seems like the build step build:vscode fails at compilation api-proposal-names -> tree-sitter-typescript:

build logs #L907:

[4/4] Building fresh packages...
warning Error running install script for optional dependency: "/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments: 
Directory: /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript
Output:
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info find Python using Python version 3.11.2 found at \"/usr/bin/python3\"

gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/usr/local/lib/node_modules/npm/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/root/.cache/node-gyp/20.11.1/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/root/.cache/node-gyp/20.11.1',
gyp info spawn args '-Dnode_gyp_dir=/usr/local/lib/node_modules/npm/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/root/.cache/node-gyp/20.11.1/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript/build'
  CC(target) Release/obj.target/tree_sitter_typescript_binding/typescript/src/parser.o
In file included from ../typescript/src/parser.c:1:
../typescript/src/parser.c: In function 'ts_lex_keywords':
../typescript/src/tree_sitter/parser.h:136:8: warning: variable 'eof' set but not used [-Wunused-but-set-variable]
  136 |   bool eof = false;             \\\n      |        ^~~
../typescript/src/parser.c:10363:3: note: in expansion of macro 'START_LEXER'
10363 |   START_LEXER();
      |   ^~~~~~~~~~~
  CC(target) Release/obj.target/tree_sitter_typescript_binding/typescript/src/scanner.o
  CC(target) Release/obj.target/tree_sitter_typescript_binding/tsx/src/parser.o
In file included from ../tsx/src/parser.c:1:
../tsx/src/parser.c: In function 'ts_lex_keywords':
../typescript/src/tree_sitter/parser.h:136:8: warning: variable 'eof' set but not used [-Wunused-but-set-variable]
  136 |   bool eof = false;             \\\n      |        ^~~
../tsx/src/parser.c:10[951](https://ci.ocram85.com/repos/2/pipeline/32/3#L951):3: note: in expansion of macro 'START_LEXER'
10951 |   START_LEXER();
      |   ^~~~~~~~~~~
  CC(target) Release/obj.target/tree_sitter_typescript_binding/tsx/src/scanner.o
  CXX(target) Release/obj.target/tree_sitter_typescript_binding/bindings/node/binding.o
In file included from ../../nan/nan.h:178,
                 from ../bindings/node/binding.cc:3:
../../nan/nan_callbacks.h:55:23: error: 'AccessorSignature' is not a member of 'v8'
   55 | typedef v8::Local<v8::AccessorSignature> Sig;
      |                       ^~~~~~~~~~~~~~~~~
../../nan/nan_callbacks.h:55:40: error: template argument 1 is invalid
   55 | typedef v8::Local<v8::AccessorSignature> Sig;
      |                                        ^
../../nan/nan.h: In function 'void Nan::SetAccessor(v8::Local<v8::ObjectTemplate>, v8::Local<v8::String>, GetterCallback, SetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, imp::Sig)':
../../nan/nan.h:2544:19: error: no matching function for call to 'v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>&, void (*&)(v8::Local<v8::Name>, const v8::PropertyCallbackInfo<v8::Value>&), void (*&)(v8::Local<v8::Name>, v8::Local<v8::Value>, const v8::PropertyCallbackInfo<void>&), v8::Local<v8::Object>&, v8::AccessControl&, v8::PropertyAttribute&, Nan::imp::Sig&)'
 2544 |   tpl->SetAccessor(
      |   ~~~~~~~~~~~~~~~~^
 2545 |       name
      |       ~~~~         
 2546 |     , getter_
      |     ~~~~~~~~~      
 2547 |     , setter_
      |     ~~~~~~~~~      
 2548 |     , obj
      |     ~~~~~          
 2549 |     , settings
      |     ~~~~~~~~~~     
 2550 |     , attribute
      |     ~~~~~~~~~~~    
 2551 |     , signature);
      |     ~~~~~~~~~~~~   
In file included from /root/.cache/node-gyp/20.11.1/include/node/v8-function.h:15,
                 from /root/.cache/node-gyp/20.11.1/include/node/v8.h:33,
                 from /root/.cache/node-gyp/20.11.1/include/node/node.h:73,
                 from ../bindings/node/binding.cc:2:
/root/.cache/node-gyp/20.11.1/include/node/v8-template.h:809:8: note: candidate: 'void v8::ObjectTemplate::SetAccessor(v8::Local<v8::String>, v8::AccessorGetterCallback, v8::AccessorSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)'
  809 |   void SetAccessor(
      |        ^~~~~~~~~~~
/root/.cache/node-gyp/20.11.1/include/node/v8-template.h:814:22: note:   no known conversion for argument 7 from 'Nan::imp::Sig' {aka 'int'} to 'v8::SideEffectType'
  814 |       SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
      |       ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/.cache/node-gyp/20.11.1/include/node/v8-template.h:816:8: note: candidate: 'void v8::ObjectTemplate::SetAccessor(v8::Local<v8::Name>, v8::AccessorNameGetterCallback, v8::AccessorNameSetterCallback, v8::Local<v8::Value>, v8::AccessControl, v8::PropertyAttribute, v8::SideEffectType, v8::SideEffectType)'
  816 |   void SetAccessor(
      |        ^~~~~~~~~~~
/root/.cache/node-gyp/20.11.1/include/node/v8-template.h:821:22: note:   no known conversion for argument 7 from 'Nan::imp::Sig' {aka 'int'} to 'v8::SideEffectType'
  821 |       SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect,
      |       ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../bindings/node/binding.cc: At global scope:
/root/.cache/node-gyp/20.11.1/include/node/node.h:1172:7: warning: cast between incompatible function types from 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Object>)' to 'node::addon_register_func' {aka 'void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, void*)'} [-Wcast-function-type]
 1172 |       (node::addon_register_func) (regfunc),                          \\\n      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/root/.cache/node-gyp/20.11.1/include/node/node.h:1206:3: note: in expansion of macro 'NODE_MODULE_X'
 1206 |   NODE_MODULE_X(modname, regfunc, NULL, 0)  // NOLINT (readability/null_usage)
      |   ^~~~~~~~~~~~~
../bindings/node/binding.cc:35:1: note: in expansion of macro 'NODE_MODULE'
   35 | NODE_MODULE(tree_sitter_typescript_binding, Init)
      | ^~~~~~~~~~~
make: *** [tree_sitter_typescript_binding.target.mk:119: Release/obj.target/tree_sitter_typescript_binding/bindings/node/binding.o] Error 1
make: Leaving directory '/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:209:23)
gyp ERR! System Linux 5.4.0-189-generic
gyp ERR! command \"/usr/local/bin/node\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"
gyp ERR! cwd /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/build/node_modules/tree-sitter-typescript
gyp ERR! node -v v20.11.1
gyp ERR! node-gyp -v v10.0.1
gyp ERR! not ok"
info This module is OPTIONAL, you can safely ignore this error

leads to #L1459

[18:36:19] Starting compilation api-proposal-names...
Unhandled Rejection at: Promise Promise {
  <rejected> Error: bad export type for `tree_sitter_tsx_external_scanner_create`: undefined
      at reportUndefinedSymbols (/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:19748)
      at postInstantiation (/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:17027)
      at /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:17752
      at async /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/@vscode/l10n-dev/dist/main.js:329:10
      at async /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/@vscode/l10n-dev/dist/main.js:318:22
} reason: Error: bad export type for `tree_sitter_tsx_external_scanner_create`: undefined
    at reportUndefinedSymbols (/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:19748)
    at postInstantiation (/woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:17027)
    at /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/web-tree-sitter/tree-sitter.js:1:17752
    at async /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/@vscode/l10n-dev/dist/main.js:329:10
    at async /woodpecker/src/gitea.********.com/OCram85/code-server/lib/vscode/node_modules/@vscode/l10n-dev/dist/main.js:318:22
[18:36:20] The following tasks did not complete: vscode-reh-web-linux-x64-min
[18:36:20] Did you forget to signal async completion?
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Any idea what could cause this?

[code-asher]

Maybe unrelated, but are you applying the patches somewhere else? I did not see it in the ci.yml.

I have no idea what that error means but I tried using the same image by hand and had no errors:

docker run --rm -it node:20.11.1 bash
echo 'deb [trusted=yes] https://repo.goreleaser.com/apt/ /' | tee /etc/apt/sources.list.d/goreleaser.list
apt-get update
apt-get install -y nfpm
apt-get install -y build-essential ca-certificates curl dbus g++ gettext git gnupg jq libgbm1 libgtk-3-0 libkrb5-dev libsecret-1-dev libx11-dev libxkbfile-dev libxss1 pkg-config python-is-python3 python3 rsync xvfb    
apt install quilt -y
git clone https://github.com/coder/code-server
cd code-server
git submodule update --init
quilt push -a
yarn install
yarn build
export VERSION='0.0.0' && yarn build:vscode

[OCram85]

I'm still testing the builds with my WoodpeckerCI workflow

#...
#...
steps:
  build:
    #image: node:18.20.2
    image: node:20.11.1
    commands:
      - |
        echo 'deb [trusted=yes] https://repo.goreleaser.com/apt/ /' | tee /etc/apt/sources.list.d/goreleaser.list
        apt-get update
        apt-get install -y nfpm
        apt-get install -y build-essential \
          ca-certificates \
          curl \
          dbus \
          g++ \
          gettext\
          git \
          gnupg \
          jq \
          libgbm1 \
          libgtk-3-0 \
          libkrb5-dev \
          libsecret-1-dev \
          libx11-dev \
          libxkbfile-dev \
          libxss1 \
          pkg-config \
          python-is-python3 \
          python3 \
          rsync \
          xvfb
      - yarn install
      - yarn build
      - export VERSION='0.0.0' && yarn build:vscode
      - yarn release
      - yarn release:standalone
      - yarn package
      - ls -la release-packages/*
#...
#...

Ohh, never noticed I have to run quilt manually - Always thought it's integrated in the npm scripts or ~/ci/build/*.sh scripts 🤔

[OCram85]

Tried to add the quilt patches in front of yarn install and afterwards,but both fails due to rejected patches:

+ quilt push -a
Applying patch patches/integration.diff
patching file lib/vscode/src/vs/server/node/server.main.ts
patching file lib/vscode/src/vs/base/common/processes.ts
patching file lib/vscode/src/vs/workbench/browser/parts/dialogs/dialogHandler.ts
patching file lib/vscode/src/vs/workbench/browser/client.ts
patching file lib/vscode/src/vs/workbench/browser/web.main.ts
patching file lib/vscode/src/vs/base/common/product.ts
patching file lib/vscode/src/vs/code/browser/workbench/workbench-dev.html
patching file lib/vscode/src/vs/code/browser/workbench/workbench.html
patching file lib/vscode/src/vs/server/node/webClientServer.ts
Hunk #1 FAILED at 307.
1 out of 1 hunk FAILED -- rejects in file lib/vscode/src/vs/server/node/webClientServer.ts
Patch patches/integration.diff does not apply (enforce with -f)

update

... seems to be related to my local current branch / pr 👼 😠

[code-asher]

Ohh, never noticed I have to run quilt manually - Always thought it's integrated in the npm scripts or ~/ci/build/*.sh scripts

Ahh yeah a reasonable assumption honestly, but there are a few tricky things about trying to do it automatically.

1 out of 1 hunk FAILED -- rejects in file lib/vscode/src/vs/server/node/webClientServer.ts

Usually this means the VS Code version is incorrect, although I am not sure how it could be since I assume CI is cloning both code-server and the sub-module together. 🤔