Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password hash to use sufficient computational effort #3381

Closed
jsjoeio opened this issue May 12, 2021 · 0 comments · Fixed by #3422
Closed

Fix password hash to use sufficient computational effort #3381

jsjoeio opened this issue May 12, 2021 · 0 comments · Fixed by #3422
Assignees
@jsjoeio
Labels
security Security related
Milestone
3.11.0

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented May 12, 2021

Issue identified by CodeQL in src/node/util.ts

See issue explanation and recommendation: https://github.com/cdr/code-server/security/code-scanning/20?query=ref%3Arefs%2Fheads%2Fmain
@jsjoeio jsjoeio added the security Security related label May 12, 2021
@jsjoeio jsjoeio added this to the v3.11.0 milestone May 12, 2021
@jsjoeio jsjoeio self-assigned this May 12, 2021
@jsjoeio jsjoeio mentioned this issue May 12, 2021
Closed
@code-asher code-asher modified the milestones: v3.10.1, 3.11.0 May 17, 2021
@jsjoeio jsjoeio mentioned this issue May 19, 2021
Merged
5 tasks
@jsjoeio jsjoeio modified the milestones: 3.10.2, 3.11.0 May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsjoeio jsjoeio

Labels
security Security related
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

fix: use sufficient computational effort for password hash coder/code-server
2 participants
@jsjoeio @code-asher