Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve authentication flow with auth token #3546

Open
jsjoeio opened this issue Jun 4, 2021 · 2 comments
Open

Improve authentication flow with auth token #3546

jsjoeio opened this issue Jun 4, 2021 · 2 comments
Labels
enhancement Some improvement that isn't a feature security Security related
Milestone

Comments

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 4, 2021

Add token exchange. Create token on server and use as a cookie on the client.

We should use this as a default and issue a deprecation warning to anyone using the old methods.

See: #3422 (comment)

Edit: VS Code web already has token auth that we disable, could we make use of this? Then it should be pretty easy.

@jsjoeio jsjoeio added enhancement Some improvement that isn't a feature security Security related labels Jun 4, 2021
@jsjoeio jsjoeio added this to the Backlog milestone Jun 4, 2021
@antofthy
Copy link

OR the ability to set the 'session token' the server is to use!

I am very interested in being able to pre-set the session token cookie in the users browser (where they have already been authenticated).

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 3, 2022

Yes! That would be nice too.

Not a huge priority for us but if you wanted to take a swing or do some research, that would be welcome! I believe this functionality exists in VS Code. We would just have to use it and connect it with code-server's existing auth flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature security Security related
Projects
None yet
Development

No branches or pull requests

2 participants