Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coder/code-server conflicts with the startup command of visual studio code server[Bug]: #5502

Closed
4 tasks done
2659170494 opened this issue Aug 25, 2022 · 17 comments
Closed
4 tasks done

Comments

@2659170494
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser:Chrome
  • Local OS:Windows
  • Remote OS:Ubuntu
  • Remote Architecture:amd64
  • code-server --version:4.4.0

Steps to Reproduce

1To install the coder/code-server (or visual studio code server)
2.run "code-server" then you will see the estimated results
3.instal the visual studio code server (or coder/code-server)
4. run "code-server" then you will find that the results are different from the original ones

Expected

This will start code server before installation

Actual

After installing visual studio code server, the startup command of visual studio code server overwrites the original startup command. However, the original code server startup sh file can still be found by searching

Logs

No has log

Screenshot/Video

No response

Does this issue happen in VS Code or GitHub Codespaces?

  • I cannot reproduce this in VS Code.
  • I cannot reproduce this in GitHub Codespaces.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

The code server file of visual studio code server is located in /usr/local/bin/, and this file may be a binary file

At present, visual studio code server is still under internal test, so few people may have this bug before it is officially launched. I want to know if code server has any startup commands other than code server?

@2659170494 2659170494 added bug Something isn't working triage This issue needs to be triaged by a maintainer labels Aug 25, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 25, 2022

After installing visual studio code server, the startup command of visual studio code server overwrites the original startup command.

I feel like this bug should be filed with them, don't you think? That shouldn't be overwriting our startup command. They should check for conflicts and handle them if they exist. Have you tried contacting them about it?

@2659170494
Copy link
Author

After installing visual studio code server, the startup command of visual studio code server overwrites the original startup command.

I feel like this bug should be filed with them, don't you think? That shouldn't be overwriting our startup command. They should check for conflicts and handle them if they exist. Have you tried contacting them about it?

Yes, I just got the qualification of internal test. After the problem occurs, I put forward the issue in both the internal test warehouse and this warehouse. However, what they got was that because the warehouse was not Microsoft, they could not solve the problem and closed the issue

@benz0li
Copy link
Contributor

benz0li commented Aug 29, 2022

@jsjoeio I think @2659170494 is talking about #5417 (comment), i.e. executing code-server in code-server Terminal not being the same as executing code-server in a [regular] JupyterLab Terminal (e.g. https://demo.jupyter.b-data.ch).

@benz0li
Copy link
Contributor

benz0li commented Aug 29, 2022

The only thing theirs [Microsoft's] does not support is launching a new instance of code-server (it only supports interacting with the current instance of code-server) but I have no idea if that is a common use in the integrated terminal.

Originally posted by @code-asher in #5360 (comment)

@jsjoeio
Copy link
Contributor

jsjoeio commented Aug 29, 2022

executing code-server in code-server Terminal not being the same as executing code-server in a [regular] JupyterLab Terminal

Ohhh...Whoops! Sorry for the confusion. Thanks for pointing that out @benz0li. @2659170494 does that sound right? You're trying to execute code-server in a JupyterLab Terminal?

@benz0li
Copy link
Contributor

benz0li commented Aug 29, 2022

You're trying to execute code-server in a JupyterLab Terminal?

@2659170494 Or any regular Terminal [other than code-server Terminal]?

@2659170494
Copy link
Author

You're trying to execute in a JupyterLab Terminal?code-server

@2659170494 Or any regular Terminal [other than code-server Terminal]?

executing code-server in code-server Terminal not being the same as executing code-server in a [regular] JupyterLab Terminal

Ohhh...Whoops! Sorry for the confusion. Thanks for pointing that out @benz0li. @2659170494 does that sound right? You're trying to execute in a JupyterLab Terminal?code-server

Maybe, I use SSH to control my server. I haven't used other terminal software, and my server is an ordinary Ubuntu system (but I started the jupyterlab terminal mentioned by benz0li according to the link he gave, but the server was started incorrectly 🤔)。 I mean the conflict of startup commands. When I run code server, the server starts visual studio code server instead of code server. Visual studio code server replaces the startup command of code server during installation

@benz0li
Copy link
Contributor

benz0li commented Aug 30, 2022

(but I started the jupyterlab terminal mentioned by benz0li according to the link he gave, but the server was started incorrectly 🤔)

If the server at https://demo.jupyter.b-data.ch does not start, simply give it another try.

@benz0li
Copy link
Contributor

benz0li commented Aug 30, 2022

@2659170494 When you talk about Visual Studio Code Server you mean https://code.visualstudio.com/docs/remote/vscode-server, correct?

@2659170494
Copy link
Author

@2659170494当你谈论_Visual Studio Code Server_时,你的意思是 https://code.visualstudio.com/docs/remote/vscode-server,对吗?

Yes, I have only recently obtained the qualification for internal testing

@2659170494
Copy link
Author

(但是我根据Benz0li给出的链接启动了benz0li提到的jupyterlab终端,但是服务器启动不正确🤔)

如果处于 https://demo.jupyter.b-data.ch 的服务器无法启动,只需再试一次即可。

OK, I just started it successfully😂

@benz0li
Copy link
Contributor

benz0li commented Aug 30, 2022

[Using wget -O- https://aka.ms/install-vscode-server/setup.sh | sh] Visual Studio Code Server installs at /usr/local/bin.

[Using dpkg -i code-server_4.6.0_amd64.deb] coder/code-server installs at /usr/bin.

$ cat /usr/bin/code-server
#!/usr/bin/env sh

exec /usr/lib/code-server/bin/code-server "$@"

ℹ️ I do not see any files getting overwritten.

But trying to start coder/code-server by executing code-server from within Visual Studio Code Server's integrated Terminal or vice versa will fail, because the PATH gets overwritten.


I advise against installing Visual Studio Code Server and coder/code-server on the same machine.

@benz0li
Copy link
Contributor

benz0li commented Aug 30, 2022

When I run code server, the server starts visual studio code server instead of code server. Visual studio code server replaces the startup command of code server during installation

No. /usr/local/bin simply takes precedence over /usr/bin.

echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

@2659170494
Copy link
Author

When I run code server, the server starts visual studio code server instead of code server. Visual studio code server replaces the startup command of code server during installation

No. simply takes precedence over ./usr/local/bin``/usr/bin

echo $PATH
/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin

Yes, I know that. I can also start code server under the code folder of code server. However, I am more concerned about whether there are other startup commands for code server?

@code-asher
Copy link
Member

I am not sure I followed the issue, but if you install code-server then you install something else on the PATH that also has a binary called code-server, then there is nothing we can do about that conflict.

However, I am more concerned about whether there are other startup commands for code server?

code-server is the only command we have.

@code-asher code-asher closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
@code-asher code-asher removed bug Something isn't working triage This issue needs to be triaged by a maintainer labels Jul 12, 2024
@2659170494
Copy link
Author

2659170494 commented Jul 13, 2024

I am not sure I followed the issue, but if you install code-server then you install something else on the PATH that also has a binary called code-server, then there is nothing we can do about that conflict.

However, I am more concerned about whether there are other startup commands for code server?

code-server is the only command we have.

Ah, it looks like this is a very old issue.

I also raised the same issue in the repositories of VSCode remote release when this issue was released.
However, they also have no intention of dealing with this issue😂

Now when I roughly review the documents, it seems that they no longer use this command, or in other words, the problem has already been solved by them?

@code-asher
Copy link
Member

Oh yes you are right, this is quite old.

Yeah I think their command is now called code, maybe it used to be called code-server?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants