-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Missing dependencies (minimist, yauzl, yazl) #5530
Comments
completely unrelated |
Installing with yarn with code-server v4.6.1 gives the same error as the npm install. (side note, npm for v4.6.0 and below don't work on my system due to node-gyp issues) |
Same error after installing code-server on my raspberry pi using npm |
So it's not installing some dependencies 🤔 @edvincent any insight here since you're the npm expert? I wonder if it's because of node-gyp issues or some native dependencies or something. |
🤓😬😂 Are all of the installs using ARM & Windows? I don't have my RPi handy until this evening so I can't test myself... But I saw similar errors in the past when some of the nested install commands would fail - and unfortunately the logging sometimes get swallowed. Anyone can try to run |
Ok able to reproduce on Ubuntu 22.04 on an ARM instance. Seems a problem with the underlying dependencies of
|
A short term hack/workaround: after the global install, go to the |
I suspect it's an issue with how the combo
Likely the |
And the explanation is the same that from #4918 and comes in https://github.com/npm/node-semver#prerelease-tags: pre-release tags are in a different "namespace". Not sure why |
I guess yarnpkg/yarn#3361 would explain that... |
Relevant discussion for Brainstorming on next steps/fixes - happy to hear thoughts/other ideas:
And either way, need to sanity check why logging for the nested commands is not being bubbled up to the user... |
I think we're going to try this for now to unblock installing via npm. see: #5533 Once CI passes, we'll publish 4.6.1-1 on npm manually to unblock people and allow us to publish to homebrew: Homebrew/homebrew-core#109430 Not sure which of those solutions are best. cc @code-asher side note: @edvincent your investigation/notes are super thorough and you found all this super fast!!! Thank you! |
Unfortunately I get error while installing
seems to be an error with the |
I tried installing this three packages with npm globally and it seems the problem is solved |
Yes, thanks! On FreeBSD also had to add |
I got an error installing
It was resolved by deleting |
Exactly the same problem was found on Windows Server 2022. [email protected] |
I tried to run: npm install --global @microsoft/1ds-core-js minimist yauzl and restart device, but it doesn't working. |
@Initial-heart-1 you missed quite a few packages try:
I think this is coming from y'alls lack of understanding of the new yarn and some things. right now if you're on a corepack enabled node version, anything past 16.17.0, and use a non yarn 1.22.19 install it all blows up. if this is your current hell hole here's how you can make this package run as if yarn 1 is the only yarn that exists: export const installCodeServer = () => {
spawnSync('corepack', ['[email protected]', 'global', 'add', '[email protected]'])
// without these globals it doesn't work
spawnSync('corepack', ['[email protected]', 'global', 'add', '@microsoft/1ds-core-js', 'minimist', 'yauzl', 'yazl', 'spdlog'])
process.stdout.write('code-server version 4.11.0 installed\n')
} |
After installing code-server(v4.11.0) on my Raspberry Pi 3(OS: Raspbian GNU/Linux 11) with npm(node v16.16.0): npm i -g @microsoft/1ds-core-js minimist yauzl yazl spdlog xterm-headless
sudo apt install libsecret-1-dev then changed into the npm i --legacy-peer-deps Eventually code-server works as expected. |
v4.12.0 still have this problem, it need to install vscode's node_modules manually: cd path_to_global_node_modules/codeserver/lib/vscode && npm i . --production --force after installed, code-server can start up successfully. seams the npm post install script should add this step |
Oh, not so good...I seem to have been successful in the solution to this problem, because it has indeed worked well on my server for a while, but I seem to forget what I did... |
info? it still persist on latest version |
Issue persists September 10, 2023. Any updates? |
Please use docker and code-server-python. It is tested on RPI4 Pi OS 64-bit. For 32-bit, you have to build the image manually. You can modify the base image to work with other frameworks. |
Does this still persist in the latest version? I am not sure there are any errors on our end, we already install modules as part of the postinstall: code-server/ci/build/npm-postinstall.sh Lines 145 to 147 in 6a14070
|
Is there an existing issue for this?
OS/Web Information
code-server --version
:Steps to Reproduce
npm --global i code-server --unsafe-perm
Expected
No errors: webpage should display
Actual
Errors appear
Logs
Screenshot/Video
No response
Does this issue happen in VS Code or GitHub Codespaces?
Are you accessing code-server over HTTPS?
Notes
There are other errors when not installing globally (such as a 404 error).
The text was updated successfully, but these errors were encountered: