Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External URLs using wrong URL from cache #6024

Open
code-asher opened this issue Feb 16, 2023 · 1 comment
Open

External URLs using wrong URL from cache #6024

code-asher opened this issue Feb 16, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@code-asher
Copy link
Member

I found there's a conflict between this feature and url displayed in open external uri dialog.
If you open an external uri for the first time then the domain of it will be resolved to cache in map data structure.
Like https://www.w3schools.com/c/c_structs.php
image

For the next time if you open a different uri with the same domain
Like https://github.com/coder/code-server/issues
it will be resolved as the last uri which has been cached.
image

The uri displayed here is not correct

Before there's no resolvers registered by default so external uri is not resolved but after this feature added, cache will take effect
image

Hope there's a solutaion for this. Thank you!

Originally posted by @ericzhucode in #5624 (comment)

@code-asher code-asher added the bug Something isn't working label Feb 16, 2023
@code-asher
Copy link
Member Author

I am not sure if this is still an issue but we should try reproducing in Codespaces if it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant