Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-api should use official AWS_SHARED_CREDENTIALS_FILE for providing the coordinates to the credentials file #188

Closed
FieryCod opened this issue Jun 29, 2021 · 4 comments
Closed

aws-api should use official AWS_SHARED_CREDENTIALS_FILE for providing the coordinates to the credentials file #188

FieryCod opened this issue Jun 29, 2021 · 4 comments

Comments

@FieryCod
Copy link

Patch for this issue is here: #187
@FieryCod FieryCod changed the title aws-api should use AWS_SHARED_CREDENTIALS_FILE for providing the coordinates to the credentials file aws-api should use official AWS_SHARED_CREDENTIALS_FILE for providing the coordinates to the credentials file Jun 29, 2021
@dchelimsky dchelimsky mentioned this issue May 9, 2022
Closed
@dchelimsky
Copy link
Contributor

Thanks for the patch, but we don't accept PRs.

That said, the docs you referenced make no mention of the AWS_CREDENTIAL_PROFILES_FILE we're using, so we may end up deprecating support for that var as we add support for AWS_SHARED_CREDENTIALS_FILE in order to align w/ the AWS CLI.

@dchelimsky
Copy link
Contributor

Actually, the java sdk v1 uses AWS_SHARED_CREDENTIALS_FILE, so we'll keep it.

@dchelimsky
Copy link
Contributor

c9c4410

I'll leave this open until it's released.

@dchelimsky
Copy link
Contributor

Released today with aws-api-0.5.561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dchelimsky @FieryCod