Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

301 gets :cognitect.anomlies/fault #237

Closed
dchelimsky opened this issue Apr 26, 2023 · 3 comments
Closed

301 gets :cognitect.anomlies/fault #237

dchelimsky opened this issue Apr 26, 2023 · 3 comments

Comments

@dchelimsky
Copy link
Contributor

Dependencies

{:deps {com.cognitect.aws/api       {:mvn/version "0.8.664"}
        com.cognitect.aws/endpoints {:mvn/version "1.1.12.456"}
        com.cognitect.aws/s3        {:mvn/version "847.2.1365.0"}}}

Description with failing test case

Release 0.8.664 added status and headers when we get a 301 (along with other non-2xx's), so users can detect the 301 and do the right thing. One thing that would improve this slightly is returning an anomaly/category of incorrect instead of fault (which is a catch-all). This would be more precise.

@dchelimsky
Copy link
Contributor Author

Changed to :cognitect.anomalies/incorrect in 0.8.666

@dchelimsky dchelimsky reopened this May 2, 2023
@dchelimsky
Copy link
Contributor Author

I thought I'd fixed this, but later learned that, due to the fat AWS does not provide a Location header with a 301, the jetty client is throwing an exception which pushes control through a different part of the code. Investigating.

@dchelimsky
Copy link
Contributor Author

Fixed in 0.8.673 (it was fixed in 0.8.670, but that had a perf warning, so don't use that one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant