Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructor package scaffold + basic primitives #104

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Add constructor package scaffold + basic primitives #104

merged 3 commits into from
Aug 18, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 18, 2020 •
edited
Loading

Related: coinbase/mesh-cli#112

Changes

  • Add new Construction API testing framework
  • Add generate_key primitive
  • Add derive primitive
  • Add set_variable primitive
  • Add tests for worker and processor

Future PR

  • Add tests for broadcast functionality in Job

@patrick-ogrady patrick-ogrady changed the title Add constructor package Add constructor package primitives Aug 18, 2020
@patrick-ogrady patrick-ogrady mentioned this pull request Aug 18, 2020
Closed
30 tasks
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4055

  • 115 of 209 (55.02%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 74.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
types/utils.go 0 8 0.0%
constructor/worker.go 56 76 73.68%
constructor/job.go 37 103 35.92%
Totals Coverage Status
Change from base Build 3914: -0.8%
Covered Lines: 3875
Relevant Lines: 5169
💛 - Coveralls

@patrick-ogrady patrick-ogrady requested review from juliankoh, yfl92, a team and niallo August 18, 2020 19:43
@patrick-ogrady patrick-ogrady changed the title Add constructor package primitives Add constructor package scaffold + basic primitives Aug 18, 2020
@patrick-ogrady patrick-ogrady merged commit 4db8c1f into master Aug 18, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/constructor-package branch August 18, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliankoh juliankoh juliankoh approved these changes

@yfl92 yfl92 Awaiting requested review from yfl92

@niallo niallo Awaiting requested review from niallo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @juliankoh