-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construction API Coordinator #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30bfc48
to
361a9bd
Compare
Pull Request Test Coverage Report for Build 4874
💛 - Coveralls |
a9403f7
to
030e608
Compare
30 tasks
030e608
to
bf0c312
Compare
bf0c312
to
b00a890
Compare
juliankoh
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: coinbase/mesh-cli#112
This PR includes an implementation of the
coordinator
(the core processor for theconstructor
). To better test thiscoordinator
, this PR also includes a refactor of theconstructor
into two separate packagesexecutor
andcoordinator
.Changes
coordinator
which orchestrates the execution of jobs, the creation of jobs, and the running of reserved workflowscoordinator
AllBroadcasts
should be a function on JobStorage instead ofBroadcastStorage