Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction API Coordinator #114

Merged
merged 19 commits into from
Aug 24, 2020
Merged

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Aug 22, 2020

Related Issue: coinbase/mesh-cli#112

This PR includes an implementation of the coordinator (the core processor for the constructor). To better test this coordinator, this PR also includes a refactor of the constructor into two separate packages executor and coordinator.

Changes

  • Implement coordinator which orchestrates the execution of jobs, the creation of jobs, and the running of reserved workflows
  • Add tests for coordinator
  • AllBroadcasts should be a function on JobStorage instead of BroadcastStorage
  • Test 2-step job

@patrick-ogrady patrick-ogrady force-pushed the patrick/construction-coordinator branch from 30bfc48 to 361a9bd Compare August 22, 2020 00:03
@coveralls
Copy link

coveralls commented Aug 22, 2020

Pull Request Test Coverage Report for Build 4874

  • 221 of 332 (66.57%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.6%) to 76.726%

Changes Missing Coverage Covered Lines Changed/Added Lines %
constructor/executor/worker.go 20 31 64.52%
constructor/coordinator/coordinator.go 201 301 66.78%
Totals Coverage Status
Change from base Build 4763: -0.6%
Covered Lines: 4523
Relevant Lines: 5895

💛 - Coveralls

@patrick-ogrady patrick-ogrady force-pushed the patrick/construction-coordinator branch from a9403f7 to 030e608 Compare August 22, 2020 17:24
@patrick-ogrady patrick-ogrady changed the title [WIP] Construction API Coordinator Construction API Coordinator Aug 22, 2020
@patrick-ogrady patrick-ogrady force-pushed the patrick/construction-coordinator branch from 030e608 to bf0c312 Compare August 22, 2020 17:28
@patrick-ogrady patrick-ogrady force-pushed the patrick/construction-coordinator branch from bf0c312 to b00a890 Compare August 22, 2020 17:29
@patrick-ogrady patrick-ogrady merged commit a3f2352 into master Aug 24, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/construction-coordinator branch August 24, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants