[Fetcher] Initialize with non-primary network #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5703
💛 - Coveralls |
patrick-ogrady
force-pushed
the
patrick/fix-genesis-block-accross-sub-networks
branch
from
cd76475 to
590aaa0
Compare
patrick-ogrady
changed the title
patrick-ogrady
requested review from
cindyxkuang,
juliankoh,
qiwu7 and
yfl92
qiwu7
approved these changes
Sep 1, 2020
patrick-ogrady
deleted the
patrick/fix-genesis-block-accross-sub-networks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96
This PR makes it possible to initialize the
fetcherwith some non-default network. This is useful for Rosetta implementations that support multiple networks.Changes