Skip reconciliation when interesting account is missing #291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Error: unable to get computed balance for &{Address:0000000001 SubAccount:<nil>, Metadata:map[]}: &{Symbol: ICP Decimals:8 Metadata:map[]}: block nil
The reconciler reconciles interesting accounts at every block height. But, there is no entry for an account in balance storage until it is encountered in a block. So, when the reconciler tries to reconcile an interesting account, it hasn't encountered yet, it stops with an account missing error (
ErrAccountMissing
).ErrAccountMissing
incorrectly says "block nil".Solution