Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Construction API Methods to Fetcher #58

Merged
merged 16 commits into from
Jul 10, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Jun 30, 2020

Fixes #56
Fixes #61

Changes

Related PRs

#55

@coveralls
Copy link

coveralls commented Jun 30, 2020

Pull Request Test Coverage Report for Build 2377

  • 64 of 163 (39.26%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 65.812%

Changes Missing Coverage Covered Lines Changed/Added Lines %
asserter/construction.go 64 66 96.97%
fetcher/configuration.go 0 9 0.0%
fetcher/construction.go 0 88 0.0%
Totals Coverage Status
Change from base Build 2277: -1.6%
Covered Lines: 1873
Relevant Lines: 2846

💛 - Coveralls

@patrick-ogrady patrick-ogrady force-pushed the patrick/construction-fetcher branch from 967a142 to 8a07284 Compare July 10, 2020 19:12
@patrick-ogrady patrick-ogrady requested review from juliankoh, niallo and a team July 10, 2020 19:25
@patrick-ogrady patrick-ogrady merged commit 6f86031 into master Jul 10, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/construction-fetcher branch July 10, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Fetcher] Allow for insecure HTTPS for debugging Add Support for Construction API in Fetcher
3 participants