-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Syncer #89
Merged
Merged
Optimize Syncer #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3279
💛 - Coveralls |
c66ab43
to
28aa1a2
Compare
2 tasks
3a7af38
to
486a590
Compare
a5df3f7
to
e0f3626
Compare
qiwu7
reviewed
Aug 6, 2020
qiwu7
reviewed
Aug 6, 2020
qiwu7
reviewed
Aug 6, 2020
qiwu7
approved these changes
Aug 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
qiwu7
previously approved these changes
Aug 6, 2020
86df88e
to
081e847
Compare
juliankoh
approved these changes
Aug 6, 2020
qiwu7
approved these changes
Aug 6, 2020
yfl92
approved these changes
Aug 6, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: coinbase/mesh-cli#87
This PR greatly improves sync performance by changing syncing to be continuous instead of discrete (syncing in 1000 block chunks). Most performance gains come from keeping our IO resources in high use (previously, we wouldn't attempt to store anything while fetching the block range). I will post a chart describing the magnitude of sync speedup when merging this into the
rosetta-cli
.As a side effect, we greatly reduce memory usage by avoiding caching up to 1000 blocks in memory before processing (when the default concurrency is used, this is a memory usage reduction of 99%).
Changes
BlockConcurrency
toSyncConcurrency
BlockConcurrency
fromFetcher