Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid reference to Temporal::Api::Enums::V1::TaskQueueType::Workflow #193

Open
cdimitroulas opened this issue Sep 14, 2022 · 2 comments
Open

Comments

@cdimitroulas
Copy link

In the Temporal::Connection::GRPC#describe_task_queue method there is a reference to this enum -> Temporal::Api::Enums::V1::TaskQueueType::Workflow

A simple bit of code like this seems to suggest that this is an invalid reference as I get an error:

connection = Temporal::Connection.generate(Temporal.configuration.for_connection)
puts connection.describe_task_queue(namespace: Temporal.configuration.namespace, task_queue: Temporal.configuration.task_queue)

The error:

NameError: uninitialized constant Temporal::Api::Enums::V1::TaskQueueType::Workflow
Did you mean?  Temporal::Workflow
               Temporal::Api::Workflow

I believe that the correct reference should be Temporal::Api::Enums::V1::TaskQueueType::TASK_QUEUE_TYPE_WORKFLOW. When using that instead, then the code above runs as expected. Happy to open a PR if this is indeed the correct fix.

@antstorm
Copy link
Contributor

@cdimitroulas yes, I believe you are right and there's a bug there. A fix PR is very welcome!

@cdimitroulas
Copy link
Author

@antstorm I've opened a PR for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants