Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undercompilation of MillConfigParser.parser after change in MillConfig #2315

Closed
lefou opened this issue Feb 14, 2023 · 2 comments
Closed

Undercompilation of MillConfigParser.parser after change in MillConfig #2315

lefou opened this issue Feb 14, 2023 · 2 comments
Labels
upstream The issue originates in an upstream dependency

Comments

@lefou
Copy link
Member

lefou commented Feb 14, 2023

This is probably not an issue in Mill, but in either Zinc or mainargs.

After a clean build when changing the @arg.doc attribute of one argument in mill.MillConfig, a recompile results in only on recompiled file MillConfig.scala. The file MillConfigParser.scala gets not recompiled, yet it contains a lazy val usageText = parser.helpText() (parser is a private[this] lazy val parser: ParserForClass[MillConfig] = mainargs.ParserForClass[MillConfig]), which needs to re-evaluate once the annotated config class changes.

This results in outdate/stale help messages.

Here is a reprodcution: https://github.com/lefou/mainargs-undercompilation-reproduction

@lefou
Copy link
Member Author

lefou commented Feb 14, 2023

@lefou lefou added the upstream The issue originates in an upstream dependency label Feb 14, 2023
@lefou lefou added this to the 0.10.12 milestone Feb 24, 2023
@lefou lefou removed this from the 0.10.12 milestone Mar 9, 2023
@lihaoyi
Copy link
Member

lihaoyi commented Jul 22, 2024

Let's close this, since it's a zinc/macro problem that applies to all macros, and there's really not much can do on the Mill side of things

@lihaoyi lihaoyi closed this as completed Jul 22, 2024
@lefou lefou closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream The issue originates in an upstream dependency
Projects
None yet
Development

No branches or pull requests

2 participants