Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keypress page turn/hotkeys #9

Open
psalaets opened this issue Aug 18, 2017 · 3 comments
Open

keypress page turn/hotkeys #9

psalaets opened this issue Aug 18, 2017 · 3 comments

Comments

@psalaets
Copy link
Contributor

  • left arrow fires secondary action
  • right arrow fires primary action
  • I feel like spacebar should also fire primary action
@psalaets
Copy link
Contributor Author

@cbleslie hmm default browser behavior for spacebar is page down. Should we override that?

@cbleslie
Copy link
Contributor

cbleslie commented Aug 18, 2017

@psalaets For now, I think it's okay. Space/Enter at the OS level to activate buttons. So in theory, we can have it activate the "button". Easy to reverse if it hurts users.

@psalaets
Copy link
Contributor Author

hold off until we figure out how this affects a11y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants