Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASB withdraws one output at a time instead of emptying wallet #662

Closed
sethforprivacy opened this issue Aug 21, 2021 · 3 comments · Fixed by #717
Closed

ASB withdraws one output at a time instead of emptying wallet #662

sethforprivacy opened this issue Aug 21, 2021 · 3 comments · Fixed by #717
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@sethforprivacy
Copy link
Contributor

When attempting to empty the ASB Bitcoin wallet via withdraw-BFF, the documented behavior is that if no amount is provided it will empty the wallet.

ATM the behavior is instead withdrawing one output at a time from the wallet.
@thomaseizinger thomaseizinger added the bug Something isn't working label Aug 21, 2021
@thomaseizinger thomaseizinger changed the title [Bug] ASB withdraws one output at a time instead of emptying wallet ASB withdraws one output at a time instead of emptying wallet Aug 21, 2021
@thomaseizinger
Copy link
Contributor

That is certainly a bug although I don't quite know why that would happen.

@thomaseizinger thomaseizinger added the help wanted Extra attention is needed label Aug 24, 2021
@thomaseizinger
Copy link
Contributor

This is where the withdraw is initiated. To investigate, I would recommend starting with adding a test here where we initialize the test wallet with > 1 UTXO.

@devbordecraft devbordecraft mentioned this issue Aug 29, 2021
Closed
This was linked to pull requests Sep 6, 2021
Fetching all UTXOs when doing max_giveable #702
Closed
Fetch all utxo #717
Merged
@rishflab
Copy link
Member

rishflab commented Sep 6, 2021

resolved in PR

@rishflab rishflab closed this as completed Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch all utxo comit-network/xmr-btc-swap
Fetching all UTXOs when doing max_giveable
3 participants
@thomaseizinger @rishflab @sethforprivacy