Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormDialog problem showing data in select input #533

Closed
FlopiVG opened this issue Apr 10, 2019 · 6 comments · Fixed by #542
Closed

FormDialog problem showing data in select input #533

FlopiVG opened this issue Apr 10, 2019 · 6 comments · Fixed by #542
Assignees
Labels
🐛 Type: Bug Something isn't working

Comments

@FlopiVG
Copy link

FlopiVG commented Apr 10, 2019

Describe the bug
I have a problem when render a FormDialog modal (i think its the same for all modals) when put a Select Input inside of it and display the data the info show inside of modal and I have to scroll down to see the values.

I try to hardcode .dialog-styles-mod_dialog-content__{dinamic} class with overflow: visibleand work as spected.

To Reproduce

  1. Create a FormDialog
  2. Put as children an input field.
  3. Display the values and you can see it inside of modal and had to scroll down.

Expected behavior
See the dropdown values in front of modal.

Screenshots
image

@qmateub qmateub added the 🐛 Type: Bug Something isn't working label Apr 10, 2019
@montezume
Copy link
Contributor

Thanks for reporting this! I can take it 🤓

@montezume montezume self-assigned this Apr 10, 2019
@emmenko
Copy link
Member

emmenko commented Apr 15, 2019

We can't use overflow: visible because it breaks the normal content overflow.

image

We need to find another solution

@emmenko
Copy link
Member

emmenko commented Apr 15, 2019

This seems to be a known issue with react-select.

@montezume is looking into an advanced configuration of react-select, to render the menu into a different portal (https://react-select.com/advanced#portaling).

@montezume
Copy link
Contributor

I have a pull request open in ui-kit, 682 to help with this problem. Once that's merged and released, we can render select-inputs and fields inside of a portal, and that should solve this problem.

@emmenko
Copy link
Member

emmenko commented Apr 23, 2019

@montezume I guess this is now fixed, right?

@montezume
Copy link
Contributor

As long as users are using menuPortalTarget yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants