Crash when adding depiction

[nicolas-raoul]

screen-20250127-223545.mp4

On an image that has no depictions, tapping the depictions' pen icon that briefly appear, then adding a depiction and submitting, results in a crash:

java.lang.IllegalStateException: closed
at okio.RealBufferedSource.read(RealBufferedSource.kt:185)
at okio.ForwardingSource.read(ForwardingSource.kt:29)
at retrofit2.OkHttpCall$ExceptionCatchingResponseBody$1.read(OkHttpCall.java:290)
at okio.RealBufferedSource.select(RealBufferedSource.kt:229)
at okhttp3.internal.Util.readBomAsCharset(Util.kt:265)
at okhttp3.ResponseBody$BomAwareReader.read(ResponseBody.kt:208)
at com.google.gson.stream.JsonReader.fillBuffer(JsonReader.java:1291)
at com.google.gson.stream.JsonReader.nextNonWhitespace(JsonReader.java:1329)
at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:550)
at com.google.gson.stream.JsonReader.peek(JsonReader.java:426)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:207)
at fr.free.nrw.commons.wikidata.json.PostProcessingTypeAdapter$create$1.read(PostProcessingTypeAdapter.kt:27)
at retrofit2.converter.gson.GsonResponseBodyConverter.convert(GsonResponseBodyConverter.java:39)
at retrofit2.converter.gson.GsonResponseBodyConverter.convert(GsonResponseBodyConverter.java:27)
at retrofit2.OkHttpCall.parseResponse(OkHttpCall.java:227)
at retrofit2.OkHttpCall.execute(OkHttpCall.java:190)
at retrofit2.adapter.rxjava2.CallExecuteObservable.subscribeActual(CallExecuteObservable.java:45)
at io.reactivex.Observable.subscribe(Observable.java:12267)
at retrofit2.adapter.rxjava2.BodyObservable.subscribeActual(BodyObservable.java:34)
at io.reactivex.Observable.subscribe(Observable.java:12267)
at io.reactivex.internal.operators.observable.ObservableMap.subscribeActual(ObservableMap.java:32)
at io.reactivex.Observable.subscribe(Observable.java:12267)
at io.reactivex.internal.operators.observable.ObservableSubscribeOn$SubscribeTask.run(ObservableSubscribeOn.java:96)
at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
at java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:307)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
at java.lang.Thread.run(Thread.java:1012)

[B2gussain]

hey @nicolas-raoul i want to work on this issue can you assign this issue to me

[nicolas-raoul]

@B2gussain It is yours, thanks! :-)

As you may have noticed, the pen icon disappears quickly. So if it makes reproducing/testing easier, do not hesitate to implement this too: #6163 (totally optional though)