Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STA-140] Fish location and inconsistencies #78

Open
jacc opened this issue Mar 30, 2024 · 4 comments
Open

[STA-140] Fish location and inconsistencies #78

jacc opened this issue Mar 30, 2024 · 4 comments
Assignees
Labels
bug Something isn't working User-reported bug Created by Linear-GitHub Sync
Milestone

Comments

@jacc
Copy link
Collaborator

jacc commented Mar 30, 2024

  • Goby season and locations are incorrect
  • Tiger Trout season and locations are incorrect

Currently our fish.json file pulls from the fish.py parser - but given the fact that the wiki is not consistent with the games Fish.xnb file, we'll need to use Locations.xnb for the more up to date data.

From SyncLinear.com | STA-140

@jacc jacc self-assigned this Mar 30, 2024
@jacc jacc added bug Something isn't working User-reported bug Created by Linear-GitHub Sync labels Mar 30, 2024
@tindolt
Copy link
Contributor

tindolt commented Apr 5, 2024

I will tackle this one here. Will have a fix tonight.

@jacc
Copy link
Collaborator Author

jacc commented Apr 5, 2024

Appreciate you taking a stab @tindolt! The issue with this one is that the Fish.json apparently isn't the best source of truth for the seasons they're in. We were going to swap to using Locations.json for this, but it's a bit of a pain to process. Hope that context helps out 👍

@tindolt
Copy link
Contributor

tindolt commented Apr 6, 2024

Ok, need help?

@jacc jacc changed the title [STA-140] Tiger Trout has incorrect seasons [STA-140] Fish location and inconsistencies Apr 6, 2024
@jacc jacc pinned this issue Apr 6, 2024
@jacc
Copy link
Collaborator Author

jacc commented Apr 7, 2024

Absolutely would appreciate it @tindolt - would love if you joined our Discord as well so we could chat more there :)

@jacc jacc added this to the 3.0.0 milestone Dec 5, 2024
@jacc jacc unpinned this issue Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working User-reported bug Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants