Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastpfor: add version 0.2.0, make static-library #25808

Merged
merged 12 commits into from
Nov 25, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 3, 2024

Summary

Changes to recipe: fastpfor/*

Motivation

There are several improvements since 2022/12/25.
Disable shared build because upstream CMakeLists.txt define fastpfor as static-library.

Details

https://github.com/lemire/FastPFor/releases/tag/v0.2.0


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 1 (7611a54a990f948bf098be50767f8043c740fed1):

  • fastpfor/cci.20221225:
    Built 9 packages out of 11 (All logs)

  • fastpfor/0.1.8.cci.20240810:
    Built 9 packages out of 11 (All logs)

  • fastpfor/cci.20220205:
    Built 9 packages out of 11 (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 1 (7611a54a990f948bf098be50767f8043c740fed1):

  • fastpfor/cci.20220205:
    CI failed to create some packages (All logs)

    Logs for packageID 7324258e2df08c78f991ff16cebc46d2d9dc175d:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    -- CMAKE_C_FLAGS_RELEASE: -Wall -Wcast-align -O3 -DNDEBUG -std=c99 -msse4.1 -march=native
    -- Snappy was not found. codecssnappy and inmemorybenchmarksnappy targets are not available.
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /Users/jenkins/workspace/prod-v2/bsr/104801/ecbed/p/b/fastp0b7ea43338215/b/build/Release
    
    fastpfor/cci.20220205: Running CMake.build()
    fastpfor/cci.20220205: RUN: cmake --build "/Users/jenkins/workspace/prod-v2/bsr/104801/ecbed/p/b/fastp0b7ea43338215/b/build/Release" -- -j8
    [ 11%] Building CXX object CMakeFiles/FastPFOR.dir/src/bitpackingaligned.cpp.o
    [ 22%] Building CXX object CMakeFiles/FastPFOR.dir/src/simdbitpacking.cpp.o
    [ 33%] Building CXX object CMakeFiles/FastPFOR.dir/src/bitpacking.cpp.o
    [ 44%] Building C object CMakeFiles/FastPFOR.dir/src/streamvbyte.c.o
    [ 55%] Building CXX object CMakeFiles/FastPFOR.dir/src/bitpackingunaligned.cpp.o
    [ 66%] Building C object CMakeFiles/FastPFOR.dir/src/varintdecode.c.o
    [ 77%] Building CXX object CMakeFiles/FastPFOR.dir/src/simdunalignedbitpacking.cpp.o
    [ 88%] Building CXX object CMakeFiles/FastPFOR.dir/src/horizontalbitpacking.cpp.o
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/simdunalignedbitpacking.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/streamvbyte.c.o] Error 1
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/bitpacking.cpp.o] Error 1
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/bitpackingaligned.cpp.o] Error 1
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/bitpackingunaligned.cpp.o] Error 1
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    error: unknown target CPU 'vortex'
    note: valid target CPU values are: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge, core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512, skx, cascadelake, cooperlake, cannonlake, icelake-client, icelake-server, tigerlake, sapphirerapids, alderlake, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1, znver2, znver3, x86-64, x86-64-v2, x86-64-v3, x86-64-v4
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/simdbitpacking.cpp.o] Error 1
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/varintdecode.c.o] Error 1
    make[2]: *** [CMakeFiles/FastPFOR.dir/src/horizontalbitpacking.cpp.o] Error 1
    make[1]: *** [CMakeFiles/FastPFOR.dir/all] Error 2
    make: *** [all] Error 2
    
    fastpfor/cci.20220205: ERROR: 
    Package '7324258e2df08c78f991ff16cebc46d2d9dc175d' build failed
    fastpfor/cci.20220205: WARN: Build folder /Users/jenkins/workspace/prod-v2/bsr/104801/ecbed/p/b/fastp0b7ea43338215/b/build/Release
    ERROR: fastpfor/cci.20220205: Error in build() method, line 55
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • fastpfor/cci.20221225:
    Didn't run or was cancelled before finishing

  • fastpfor/0.1.8.cci.20240810:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ErniGH
Copy link
Contributor

ErniGH commented Nov 12, 2024

I’ve asked if they’re planning to release a new tag. Let’s wait a bit, and if not, we’ll add the version from this PR directly. 😄

lemire/FastPFor#119

@ErniGH ErniGH self-assigned this Nov 12, 2024
@toge toge changed the title fastpfor: add version 0.1.8.cci.20240810, make static-library fastpfor: add version 0.2.0, make static-library Nov 12, 2024
@toge
Copy link
Contributor Author

toge commented Nov 12, 2024

@ErniGH
Thanks a lot!
I updated this PR for 0.2.0.

ErniGH
ErniGH previously approved these changes Nov 19, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sorry for the noise 😄

@AbrilRBS AbrilRBS requested a review from ErniGH November 19, 2024 16:56
@AbrilRBS AbrilRBS removed the Failed label Nov 21, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@ErniGH ErniGH merged commit 07f3493 into conan-io:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants