Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt: add version 6.8.0 #25959

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tobiaskhuber
Copy link

Summary

Added Qt version 6.8.0

Motivation

There are several new features and bugfixes in Qt 6.8.
https://code.qt.io/cgit/qt/qtreleasenotes.git/about/qt/6.8.0/release-note.md

Details

Qt 6.8.0 has been added to the Qt recipe.


@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently missing the patches that have been applied to the previous versions.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I made the requested changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@valgur
Copy link
Contributor

valgur commented Nov 15, 2024

Qt 6.8.0 now also refuses to build when using libstdc++ without GNU extensions being enabled in the cppstd:

The check for QT_SUPPORTS_INT128 only takes place during the building of Qt itself and not in the public headers, though. Maybe the GNU extensions could be enabled automatically by the recipe in the CMakeToolchain?

The alternative would be to validate this case in validate_build() and possibly also expose an enable_int128 option if the user is ok with disabling it to keep the non-GNU cppstd.

@jcar87 What do you think?

"6.8.0":
- "base_path": "qtwebengine"
"patch_description": "Workaround for too long .rps file name"
"patch_file": "patches/c72097e_6.8.0.diff"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"patch_file": "patches/c72097e_6.8.0.diff"
"patch_file": "patches/c72097e_6.6.0.diff"

I think you can keep using the existing patch?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change it because the file that this patch applies to has changed between 6.7 and 6.8

@tobiaskhuber
Copy link
Author

These changes also seem to be necessary for qt 6.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants