Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-sitter-sql: add version 0.3.7 #26012

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 22, 2024

Summary

Changes to recipe: tree-sitter-sql/0.3.7

Motivation

There are several improvements in 0.3.7.

Details

https://github.com/DerekStride/tree-sitter-sql/releases/tag/v0.3.7
DerekStride/tree-sitter-sql@v0.3.5...v0.3.7


Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toge, take a look at the new upstream CMakeLists.txt
https://github.com/DerekStride/tree-sitter-sql/blob/v0.3.7/CMakeLists.txt

Maybe we can consider using upstreams one (with maybe a proper fix) instead of having our own(?)

@toge
Copy link
Contributor Author

toge commented Nov 22, 2024

@perseoGI
Oh I missed it.
Let me fix this PR.

@toge toge marked this pull request as draft November 22, 2024 13:34
@toge
Copy link
Contributor Author

toge commented Nov 22, 2024

@perseoGI
CMakeLists.txt was not present in the snapshot corresponding to 0.3.7 of gh-pages.
sources:

As per the official README, the release tarballs don't include the generated codes.

We don't commit the generated parser files to the main branch. Instead, you can find them on the gh-pages branch.

I will ask about it in upstream, but at this point it looks like we will have to use CMakeLists.txt from CCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants