-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all of the split values in shorthand input for SplitChainedNumberInput #6140
Comments
**Problem:** the order of the padding controls is incorrect, it follows the order of the border radius controls but should be a bit different. this is the first part of #6140 **Fix:** allow changing the order of the padding controls without changing the order of the border controls (passing it from outside) ![Image](https://github.com/user-attachments/assets/1a5b3abe-d710-4ee1-8a3c-615fb6b14133) **Manual Tests:** I hereby swear that: - [X] I opened a hydrogen project and it loaded - [X] I could navigate to various routes in Preview mode Fixes #6220 that was extracted from #6140
@lankaukk regarding the second item - do we still want it this way? I feel like we need to decide first how we handle shorthand/expanded representation of these css props |
@liady yes we still want it this way in the end. The way we handle the css props warrants a dev discussion 👍 |
@lankaukk sounds good. So maybe I'll split this ticket to two different issues, so it will be easy to track (one of them is already in its own ticket) |
hmm, I don't think I like this, this essentially introduces a second parallel way to edit the 4 properties individually!
|
Note: The first half of the original issue has been moved into #6220 and completed
The border radius and padding controls in the inspector both use the
SplitChainedNumberInput
so that you can choose edit the shorthand css property, or each value individually.However, when you set a shorthand property and then you condense it back to one value, it feels buggy because it appears as if no value for that property is set anymore. For example:
Solution:
The text was updated successfully, but these errors were encountered: