-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy dependency incorrect #44
Comments
Thanks, @DManowitz , for posting this issue. I was only trying to pin NumPy at 1.18.5 for Python 3.7 and 3.8, as shown here: https://github.com/conda-forge/arraykit-feedstock/blob/main/recipe/meta.yaml Are you using that version of Python, or you seeing this issue in a different context? If you are getting a specific error, please share it. In the mean time, even if you are using conda, you should be able to install I also notice that the Azure builds are failing; I will investigate that as well. |
I am using it with Python 3.8. I noticed the issue with arraykit v0.2.3 and static-frame v1.3.1 installed. With that combination, I got the following error when trying to import static_frame:
At that point, I started to dig into why I got that error and found the issues with the dependencies for the static-frame and arraykit conda-forge packages vs their requirements as listed in their own repos. |
I have removed the pinned NumPy for Python 3.7 and 3.8 and the build seems to work. Thanks again for pointing this out. |
I see that the NumPy pin at 1.18.5 has been removed for this package for versions 3.4 and 4.0. However, there is an additional requirement of numpy >=1.24.3 now also. The requirements.txt for arraykit only shows numpy >=1.18.5, so why has this additional requirement been added? |
Any updates on this? I see that the numpy >=1.24.3 requirement is still present for recent arraykit packages. |
Hi @DManowitz , thanks for bringing this up, and apologies for the delay. My best understanding is that this is out of my control. As you can see, the NumPy requirement that I specify in the conda recipe is numpy >= 1.18: arraykit-feedstock/recipe/meta.yaml Line 27 in 896b297
However, the conda build process, in producing the compiled packages, seems to define the requirement you are seeing elsewhere, and I do not see how I can change this. This is exactly why I was previously trying to pin 1.18.5 for Python 3.7 and 3.8. The best alternative is to use https://github.com/static-frame/static-frame/blob/master/requirements-test-backward.txt Apologies for the challenges with this, but again, I think this is out of my control. |
@flexatone I forgot to mention this earlier, but you might want to try asking in the conda-forge discussion group about this issue and someone might know the fix for it. |
As seen in the arraykit requirements.txt (https://github.com/static-frame/arraykit/blob/master/requirements.txt), since arraykit v0.2.4, the numpy dependency is numpy>=1.18.5. However, this package has the numpy dependency pinned at 1.18.5.
The text was updated successfully, but these errors were encountered: