Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package contains references to third_party folder that we remove #5

Closed
1 task done
Tobias-Fischer opened this issue May 5, 2023 · 1 comment
Closed
1 task done
Labels
bug Something isn't working

Comments

@Tobias-Fischer
Copy link
Contributor

Solution to issue cannot be found in the documentation.

  • I checked the documentation.

Issue

I was debugging conda-forge/pytorch-cpu-feedstock#166

There are several references to the third_party folder that we unvendor in their python code:
compiler.py:

def path_to_ptxas():
    base_dir = os.path.dirname(__file__)
    paths = [
        os.environ.get("TRITON_PTXAS_PATH", ""),
        os.path.join(base_dir, "third_party", "cuda", "bin", "ptxas")
    ]

and

triton_include_dir = os.path.join(base_dir, "third_party/cuda/include")

libdevice.py:

LIBDEVICE_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..", "third_party", "cuda", "lib", "libdevice.10.bc")

build_extern.py

        header_str = "LIBDEVICE_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), \"..\", \"third_party\", \"cuda\", \"lib\", \"libdevice.10.bc\")"

Will have to patch them out.

Installed packages

triton 2.0

Environment info

N/A
@Tobias-Fischer Tobias-Fischer added the bug Something isn't working label May 5, 2023
@Tobias-Fischer
Copy link
Contributor Author

Fixed in #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant