-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WebHDFS adapter query to retry failed resources #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjlange
reviewed
Jun 18, 2020
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...-adapter/src/test/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapterTest.java
Show resolved
Hide resolved
build now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, pending any changes coming from Chris.
josephthweatt
approved these changes
Jun 18, 2020
aaronilovici
approved these changes
Jun 18, 2020
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
build now please |
cjlange
suggested changes
Jun 18, 2020
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...hdfs-adapter/src/main/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapter.java
Outdated
Show resolved
Hide resolved
...-adapter/src/test/java/com/connexta/replication/adapters/webhdfs/WebHdfsNodeAdapterTest.java
Outdated
Show resolved
Hide resolved
cjlange
approved these changes
Jun 19, 2020
build now 🛠️ |
Hero-ed successfully on my machine. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the query method for the WebHDFS adapter to include failed resources from previous replication runs. The
QueryRequest
passed to the query method contains a list of failed item IDs from the previous run of replication. These items should be included in the next run to retry creating them in DDF.Who is reviewing it (please choose AT LEAST two reviewers that need to approve the PR before it can get merged)?
@cjlange
@aaronilovici
@josephthweatt
How should this be tested? (List steps with links to updated documentation)
DdfNodeAdapter
.response
variable tonull
.Any background context you want to provide?
Integration tests are not included in this pull request.
What are the relevant tickets?
Fixes #331
Screenshots (if appropriate)
Checklist: