Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container logs related tests fail #738

Closed
saschagrunert opened this issue Sep 20, 2022 · 0 comments · Fixed by #739
Closed

Container logs related tests fail #738

saschagrunert opened this issue Sep 20, 2022 · 0 comments · Fixed by #739

Comments

@saschagrunert
Copy link
Member

saschagrunert commented Sep 20, 2022

Which jobs are failing?

CRI-O GitHub actions e2e tests: https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317

Which tests are failing?

A bunch of tests asserting container logs:

Summarizing 6 Failures:
[14113](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14114)
  [FAIL] [sig-node] Variable Expansion [It] should allow composing env vars into new env vars [NodeConformance] [Conformance]
[14114](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14115)
  test/e2e/framework/util.go:773
[14115](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14116)
  [FAIL] [sig-node] Downward API [It] should provide pod name, namespace and IP address as env vars [NodeConformance] [Conformance]
[14116](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14117)
  test/e2e/framework/util.go:773
[14117](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14118)
  [FAIL] [sig-storage] EmptyDir volumes when FSGroup is specified [LinuxOnly] [NodeFeature:FSGroup] [It] new files should be created with FSGroup ownership when container is non-root
[14118](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14119)
  test/e2e/framework/util.go:773
[14119](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14120)
  [FAIL] [sig-node] Sysctls [LinuxOnly] [NodeConformance] [It] should support sysctls [MinimumKubeletVersion:1.21] [Conformance]
[14120](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14121)
  test/e2e/common/node/sysctl.go:114
[14121](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14122)
  [FAIL] [sig-node] Pods [It] should contain environment variables for services [NodeConformance] [Conformance]
[14122](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14123)
  test/e2e/common/node/pods.go:524
[14123](https://github.com/cri-o/cri-o/actions/runs/3089802460/jobs/4998634317#step:5:14124)
  [FAIL] [sig-storage] Projected combined [It] should project all components that make up the projection API [Projection][NodeConformance] [Conformance]

Since when has it been failing?

I’m unsure, they passed a while before we merged the attach fixes.

Reason for failure (if possible)

I assume that we have not written all logs on container termination and race between the CRI logger and child reaper. We probably need something to wait for the logs before exiting conmon-rs.

Anything else we need to know?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant