Feature rancher integration #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantoDE
force-pushed
the
feature-rancher-integration
branch
2 times, most recently
from
c2e26d7 to
660416b
Compare
added 5 commits
February 6, 2017 17:02
add tons of labels Provide - WIP add rancher data over rancher types first version of direct fetch - pagination still an issue
fmt & lint
lint files
SantoDE
force-pushed
the
feature-rancher-integration
branch
from
3757639 to
3a875e2
Compare
vdemeester
approved these changes
Feb 6, 2017
| @@ -0,0 +1,458 @@ | |||
| package provider | |||
|
|
|||
| import ( | |||
There was a problem hiding this comment.
Import are not in the right order 😅
|
|
||
| // Frontend Labels | ||
| func (provider *Rancher) getPassHostHeader(service rancherData) string { | ||
| if passHostHeader, err := getServiceLabel(service, "traefik.frontend.passHostHeader"); err == nil { |
There was a problem hiding this comment.
I really feel this kind of line are duplicated a lot, it's orthogonal to this PR (/me thinking outloud 🤔) but at some point I think we could refactor this to share some common code.
|
@SantoDE I will merge this one as is: could you open an issue to update doc & imports? |
|
Done @emilevauge |
|
Really keen to try this out, any chance of an example config? |
|
Hey @ashmckenzie, until PR #1127 is merged, the only way to test that feature is by providing the endpoint, access and secret key. You can find documentation in that PR here |
|
For anyone who is looking for it, here is a link to the rancher backend provider docs. |
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Provider - Rancher. I still need to do some stuff, but it's a base for discussions :)
TODO: